Bump up the version of the static UI container to avoid DAG display error #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump up the version to avoid DAG display error
savingoyal
reviewed
Mar 21, 2023
| @@ -13,7 +13,7 @@ image: | |||
| uiImage: | |||
| repository: public.ecr.aws/outerbounds/metaflow_ui | |||
| pullPolicy: IfNotPresent | |||
| tag: "v1.0.1" | |||
| tag: "v1.1.4" | |||
There was a problem hiding this comment.
That would be good. I'd like us to dogfood the latest MFGUI
There was a problem hiding this comment.
@savingoyal, So what should I do here?
There was a problem hiding this comment.
@savingoyal , still waiting for what's expected of me here - seems like there should be no problems with the proposed change.
Do you prefer all three containers (UI, service, static-ui) to be at latest? Is that what you're saying?
shrinandj
approved these changes
Mar 22, 2023
johnseekins
pushed a commit
to civic-eagle/metaflow-tools
that referenced
this pull request
Apr 3, 2023
Signed-off-by: John Seekins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With v1.0.1 and the other containers at 2.3.1/2.3.6, you see this error while fetching the dag:
TypeError: Cannot read properties of undefined (reading 'box_ends')Previous PR has fixed it similarly for terraform scripts: https://github.com/outerbounds/metaflow-tools/pull/8/files
Updating it to 1.1.4 based on Azure/GCP terraform.